You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2017/11/13 06:31:33 UTC

[GitHub] spark pull request #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaRef...

GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/19736

    [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection should produce correct field names for special characters

    ## What changes were proposed in this pull request?
    
    `val TermName: TermNameExtractor` is new in scala 2.11. For 2.10, we should use deprecated `newTermName`.
    
    ## How was this patch tested?
    
    Build locally with scala 2.10.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-22442-2.2-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19736
    
----
commit 75d89850a0141497206ed76907f9c54148713e89
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date:   2017-11-13T06:28:09Z

    Use newTermName for compatible to scala 2.10.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    thanks, merging to master!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83775/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83771/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    cc @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    Thanks @cloud-fan @felixcheung 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19736: [SPARK-22442][SQL][BRANCH-2.2][FOLLOWUP] ScalaReflection...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19736
  
    **[Test build #83775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83775/testReport)** for PR 19736 at commit [`75d8985`](https://github.com/apache/spark/commit/75d89850a0141497206ed76907f9c54148713e89).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org