[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1427: feat(new_metrics): add disk-level metric entity and migrate disk-level metrics for fs_manager

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #1427:
URL: https://github.com/apache/incubator-pegasus/pull/1427#discussion_r1159238904


##########
src/common/fs_manager.cpp:
##########
@@ -297,17 +321,29 @@ bool fs_manager::for_each_dir_node(const std::function<bool(const dir_node &)> &
 
 void fs_manager::update_disk_stat(bool check_status_changed)
 {
-    reset_disk_stat();
+    _total_capacity_mb = 0;
+    _total_available_mb = 0;

Review Comment:
   Yes, both are used in [replica_stub.cpp#L1156](https://github.com/apache/incubator-pegasus/blob/master/src/replica/replica_stub.cpp#L1156) as the response for `query_disk_info_rpc`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org