[GitHub] yurmix commented on issue #6320: Moving Average query type

[GitBox <gi...@apache.org>]

yurmix commented on issue #6320: Moving Average query type
URL: https://github.com/apache/incubator-druid/issues/6320#issuecomment-449159637
 
 
   Thanks @b-slim, sorry for the very late response, here are my answers:
   
   > When collecting the results of the inner query to compute the moving AVG, is it done in a streaming fashion or you are materializing/buffering the entire result set to run the bucket based trailing aggregate?
   
   The query uses `Sequence` all the way, but effectively I've seen that all groupBy iteration finishes before movingAverage iteration starts.
   Please see [`MovingAverageQueryRunner@run()`](https://github.com/apache/incubator-druid/pull/6430/files#diff-41837c2a60693bdeee35530e5dcfc6d5R91).
   
   > In your example i see `"type": "longMean"` and the result is a floating point number, that seems odd to me.
   
   `longMean` consumes `Long` Aggregator but returns `Double`. I can see how this is confusing and I'll look into changing that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org