You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/09/26 02:01:59 UTC

[GitHub] [spark] srowen commented on a diff in pull request #43095: [SPARK-44895][CORE][UI] Add 'daemon', 'priority' for ThreadStackTrace

srowen commented on code in PR #43095:
URL: https://github.com/apache/spark/pull/43095#discussion_r1336544255


##########
core/src/main/scala/org/apache/spark/status/api/v1/api.scala:
##########
@@ -540,19 +540,21 @@ case class ThreadStackTrace(
     lockName: Option[String],
     lockOwnerName: Option[String],
     suspended: Boolean,
-    inNative: Boolean) {
+    inNative: Boolean,
+    isDaemon: Boolean,
+    priority: Int) {

Review Comment:
   Has priority ever meant anything for Java threads? I thought it had no effect. Is this useful info?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org