You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "churromorales (via GitHub)" <gi...@apache.org> on 2023/05/02 19:16:18 UTC
[GitHub] [druid] churromorales opened a new pull request, #14201: Ephemeral storage is respected from the overlod for peon tasks
churromorales opened a new pull request, #14201:
URL: https://github.com/apache/druid/pull/14201
I noticed during testing that the ephemeral storage resource was not inherited from the overlord. We should only be overriding the specific "cpu" and "memory" resources, currently we are calculating cpu/memory and only setting those. We should inherit all the other resources and only override `cpu` and `memory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #14201: Ephemeral storage is respected from the overlod for peon tasks
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #14201:
URL: https://github.com/apache/druid/pull/14201#issuecomment-1536900944
Got it, that makes sense. It's ok to do the next step as a follow-up IMO, so I'll merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #14201: Ephemeral storage is respected from the overlod for peon tasks
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #14201:
URL: https://github.com/apache/druid/pull/14201#issuecomment-1532442694
I am not a k8s expert so this is perhaps a basic question, but: is the effect of this that task pods will end up with the same ephemeral storage requirement as the Overlord pod that launched them? If so I don't understand why this is necessarily good -- wouldn't tasks generally need different amount of storage than the Overlord?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] churromorales commented on pull request #14201: Ephemeral storage is respected from the overlod for peon tasks
Posted by "churromorales (via GitHub)" <gi...@apache.org>.
churromorales commented on PR #14201:
URL: https://github.com/apache/druid/pull/14201#issuecomment-1533377012
@gianm this is a good point, i want to inherit properly from the overlord, then have another PR to override. But first I should be doing the right thing, unless you think both can go in this PR. If you don't inherit, you use the default value, which is immutable....you can't change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #14201: Ephemeral storage is respected from the overlod for peon tasks
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #14201:
URL: https://github.com/apache/druid/pull/14201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org