You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by KyongSik-Yoon <gi...@git.apache.org> on 2016/07/28 11:13:23 UTC

[GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

GitHub user KyongSik-Yoon opened a pull request:

    https://github.com/apache/commons-bcel/pull/10

    BCEL-276 LocalVariableTypeTable is not updated when use MethodGen.

    If a method for BCI have at least one generic type of argument JVM throw java.lang.ClassFormatError due to not updated LocalVariableTable.
    
    I know there is workaround as call removeLocalVariables method.
    But I think it's better that BCEL can stay proper LocalVariableTable.
    
    This PR include unit test for reproduce a bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KyongSik-Yoon/commons-bcel BCEL-276

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-bcel/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit b0105bf90c0cdbe08f9076e24859aae07b46bcb2
Author: sam <sa...@gmail.com>
Date:   2016-07-28T11:11:03Z

    BCEL-276 LocalVariableTypeTable is not updated when use MethodGen.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

Posted by Benedikt Ritter <br...@apache.org>.
Hello Mark,

thank you for investigating this. I've reopened the issue. I currently
don't know when I will have the time to look into it, but we'll definitely
fix it before 6.1

Regards,
Benedikt

Mark Roberts <ma...@cs.washington.edu> schrieb am Mo., 12. Sep. 2016 um
18:46 Uhr:

> This issue needs to be reopened as the changes are incorrect.  I could not
> figure out the magic to do so - but I did add comments and attached the
> outline of a solution in the form of a diff file.
>
> Thank you,
> Mark Roberts
>
> > -----Original Message-----
> > From: asfgit [mailto:git@git.apache.org]
> > Sent: Monday, September 05, 2016 11:46 PM
> > To: dev@commons.apache.org
> > Subject: [GitHub] commons-bcel pull request #10: BCEL-276
> > LocalVariableTypeTable is not update...
> >
> > Github user asfgit closed the pull request at:
> >
> >     https://github.com/apache/commons-bcel/pull/10
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your reply
> > appear on GitHub as well. If your project does not have this feature
> enabled
> > and wishes so, or if the feature is enabled but not working, please
> contact
> > infrastructure at infrastructure@apache.org or file a JIRA ticket with
> INFRA.
> > ---
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

RE: [GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

Posted by Mark Roberts <ma...@cs.washington.edu>.
This issue needs to be reopened as the changes are incorrect.  I could not
figure out the magic to do so - but I did add comments and attached the
outline of a solution in the form of a diff file.

Thank you,
Mark Roberts

> -----Original Message-----
> From: asfgit [mailto:git@git.apache.org]
> Sent: Monday, September 05, 2016 11:46 PM
> To: dev@commons.apache.org
> Subject: [GitHub] commons-bcel pull request #10: BCEL-276
> LocalVariableTypeTable is not update...
> 
> Github user asfgit closed the pull request at:
> 
>     https://github.com/apache/commons-bcel/pull/10
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have
your reply
> appear on GitHub as well. If your project does not have this feature
enabled
> and wishes so, or if the feature is enabled but not working, please
contact
> infrastructure at infrastructure@apache.org or file a JIRA ticket with
INFRA.
> ---
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-bcel pull request #10: BCEL-276 LocalVariableTypeTable is not update...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-bcel/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org