You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/12/02 02:06:51 UTC
Review Request 40852: AMBARI-14147. RU: Kafka broker restart failed on
downgrade from HDP 2.3 to 2.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40852/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-14147
https://issues.apache.org/jira/browse/AMBARI-14147
Repository: ambari
Description
-------
HDP Version: 2.2.8.0-3150
Kafka service
Rolling Upgrade to 2.3.4.0-3335, then downgrade
Kafka broker restart failed on downgrade. (Upgrade had no issues)
```
Traceback (most recent call last):
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 101, in <module>
KafkaBroker().execute()
File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 217, in execute
method(env)
File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 506, in restart
self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 67, in pre_upgrade_restart
self.configure(env)
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 44, in configure
kafka()
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py\", line 53, in kafka
listeners = kafka_server_config['listeners'].replace(\"localhost\", params.hostname)
KeyError: 'listeners'",
```
This happened because the code in kafka.py is comparing against params.hdp_stack_version (which stays as HDP 2.3 during a downgrade) instead of params.version (which is the version either upgrading or downgrading to).
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py 2bd93d2
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py 3caeb6d
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml f4c7f61
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml b48184e
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 766f443
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 0c18f32
Diff: https://reviews.apache.org/r/40852/diff/
Testing
-------
EU and RU from HDP 2.2 to 2.3 followed by downgrade.
Python unit tests passed,
----------------------------------------------------------------------
Total run:839
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 40852: AMBARI-14147. RU: Kafka broker restart
failed on downgrade from HDP 2.3 to 2.2
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40852/#review108589
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py (line 47)
<https://reviews.apache.org/r/40852/#comment168040>
This was the fix, to use params.hdp_stack_version during normal operation (which only goes up to 2 digits), and params.version during RU/EU (which is correct during a downgrade).
- Alejandro Fernandez
On Dec. 2, 2015, 1:06 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40852/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 1:06 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-14147
> https://issues.apache.org/jira/browse/AMBARI-14147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HDP Version: 2.2.8.0-3150
> Kafka service
> Rolling Upgrade to 2.3.4.0-3335, then downgrade
>
> Kafka broker restart failed on downgrade. (Upgrade had no issues)
>
> ```
> Traceback (most recent call last):
> File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 101, in <module>
> KafkaBroker().execute()
> File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 217, in execute
> method(env)
> File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 506, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 67, in pre_upgrade_restart
> self.configure(env)
> File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 44, in configure
> kafka()
> File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py\", line 53, in kafka
> listeners = kafka_server_config['listeners'].replace(\"localhost\", params.hostname)
> KeyError: 'listeners'",
> ```
>
>
> This happened because the code in kafka.py is comparing against params.hdp_stack_version (which stays as HDP 2.3 during a downgrade) instead of params.version (which is the version either upgrading or downgrading to).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py 2bd93d2
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py 3caeb6d
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml f4c7f61
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml b48184e
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 766f443
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 0c18f32
>
> Diff: https://reviews.apache.org/r/40852/diff/
>
>
> Testing
> -------
>
> EU and RU from HDP 2.2 to 2.3 followed by downgrade.
> Python unit tests passed,
>
> ----------------------------------------------------------------------
> Total run:839
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40852: AMBARI-14147. RU: Kafka broker restart
failed on downgrade from HDP 2.3 to 2.2
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40852/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 3:11 a.m.)
Review request for Ambari.
Bugs: AMBARI-14147
https://issues.apache.org/jira/browse/AMBARI-14147
Repository: ambari
Description
-------
HDP Version: 2.2.8.0-3150
Kafka service
Rolling Upgrade to 2.3.4.0-3335, then downgrade
Kafka broker restart failed on downgrade. (Upgrade had no issues)
```
Traceback (most recent call last):
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 101, in <module>
KafkaBroker().execute()
File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 217, in execute
method(env)
File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 506, in restart
self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 67, in pre_upgrade_restart
self.configure(env)
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 44, in configure
kafka()
File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py\", line 53, in kafka
listeners = kafka_server_config['listeners'].replace(\"localhost\", params.hostname)
KeyError: 'listeners'",
```
This happened because the code in kafka.py is comparing against params.hdp_stack_version (which stays as HDP 2.3 during a downgrade) instead of params.version (which is the version either upgrading or downgrading to).
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py 2bd93d2
ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py 3caeb6d
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml f4c7f61
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml b48184e
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 766f443
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 0c18f32
Diff: https://reviews.apache.org/r/40852/diff/
Testing
-------
EU and RU from HDP 2.2 to 2.3 followed by downgrade.
Python unit tests passed,
----------------------------------------------------------------------
Total run:839
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez