[GitHub] [solr] athrog commented on a change in pull request #39: SOLR-15090: Allow backup storage in GCS

[GitBox <gi...@apache.org>]

athrog commented on a change in pull request #39:
URL: https://github.com/apache/solr/pull/39#discussion_r622683227



##########
File path: solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java
##########
@@ -142,6 +142,7 @@ default String getBackupLocation(String override) {
    */
   OutputStream createOutput(URI path) throws IOException;
 
+  // TODO define whether this should also create any nonexistent parent directories. (i.e. is this 'mkdir', or 'mkdir -p')

Review comment:
       To further complicate the issue, it appears something changed from Solr 8.x to 9.x -- now, Solr _expects_ it to be `mkdir -p` behavior when taking backups. As I'm cleaning up our S3 code and moving it to 9.x repo, this behavior change broke our code (b/c ours throws exceptions if the parent dir does not exist).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org