You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (Jira)" <ji...@apache.org> on 2021/05/12 23:22:00 UTC

[jira] [Commented] (SPARK-35384) Improve performance for InvokeLike.invoke

    [ https://issues.apache.org/jira/browse/SPARK-35384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343631#comment-17343631 ] 

Apache Spark commented on SPARK-35384:
--------------------------------------

User 'sunchao' has created a pull request for this issue:
https://github.com/apache/spark/pull/32527

> Improve performance for InvokeLike.invoke
> -----------------------------------------
>
>                 Key: SPARK-35384
>                 URL: https://issues.apache.org/jira/browse/SPARK-35384
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.2.0
>            Reporter: Chao Sun
>            Priority: Minor
>
> `InvokeLike.invoke` uses `map` to evaluate arguments:
> {code:java}
> val args = arguments.map(e => e.eval(input).asInstanceOf[Object])
> if (needNullCheck && args.exists(_ == null)) {
>   // return null if one of arguments is null
>   null
> } else { 
> {code}
> which seems pretty expensive if the method itself is trivial. We can change it to a plain for-loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org