You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2014/01/31 09:08:01 UTC
git commit: updated refs/heads/4.3-forward to f4db8df
Updated Branches:
refs/heads/4.3-forward a4f2f0b39 -> f4db8df66
findbugs Long comparison == -> equals()
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f4db8df6
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f4db8df6
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f4db8df6
Branch: refs/heads/4.3-forward
Commit: f4db8df66fbcb5df3cd9bbf607ede9a4d514fe4a
Parents: a4f2f0b
Author: Daan Hoogland <da...@onecht.net>
Authored: Fri Jan 31 09:07:55 2014 +0100
Committer: Daan Hoogland <da...@onecht.net>
Committed: Fri Jan 31 09:07:55 2014 +0100
----------------------------------------------------------------------
server/src/com/cloud/template/TemplateManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f4db8df6/server/src/com/cloud/template/TemplateManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java b/server/src/com/cloud/template/TemplateManagerImpl.java
index 681be4a..3bfe5c8 100755
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -1801,7 +1801,7 @@ public class TemplateManagerImpl extends ManagerBase implements TemplateManager,
}
// Don't allow to modify system template
- if (id == Long.valueOf(1)) {
+ if (Long.valueOf(1).equals(id)) {
InvalidParameterValueException ex = new InvalidParameterValueException("Unable to update template/iso of specified id");
ex.addProxyObject(String.valueOf(id), "templateId");
throw ex;