You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/29 20:27:20 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #3230: Remove negative scale check
viirya opened a new pull request, #3230:
URL: https://github.com/apache/arrow-rs/pull/3230
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I re-checked how Spark handles negative scale. Negative scale is not limited to the max scale check because it's not part of precision.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3230: Remove negative scale check
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3230:
URL: https://github.com/apache/arrow-rs/pull/3230#issuecomment-1332713597
Benchmark runs are scheduled for baseline = 9538c265b16d8f6eb3e78218941e5c816a57dbe2 and contender = 989ab8d7a28745e76296a27445bf49921ec2d1cd. 989ab8d7a28745e76296a27445bf49921ec2d1cd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/aee1328678114cecb65514ab10ed30b9...b2590cb3a48c4b4fa170e668eaeade61/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/370343f00e57489f8a4eb5cf9a8b7284...ada151a9fb7943fab93d90b50bb13fe5/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4830237eb72a41c8890ca2c274094b46...3d65d822c1d24e89bd211cee52ced969/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/77522035ee884053833554d4709bfcad...88a5515311334edbab318c37df29c4b3/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3230: Remove negative scale check
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3230:
URL: https://github.com/apache/arrow-rs/pull/3230#issuecomment-1331837932
FWIW C++ arrow does have this check https://github.com/apache/arrow/blob/91ee6dad722ee154d63eea86ce5644e1e658b53b/cpp/src/arrow/util/decimal.cc#L389
But I agree it doesn't really make much sense. We likely need to update some assertion message as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3230: Remove negative scale check
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3230:
URL: https://github.com/apache/arrow-rs/pull/3230#issuecomment-1332630341
I believe this should also update the doc comment on `Decimal128Array` and `Decimal256Array`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3230: Remove negative scale check
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3230:
URL: https://github.com/apache/arrow-rs/pull/3230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3230: Remove negative scale check
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #3230:
URL: https://github.com/apache/arrow-rs/pull/3230#issuecomment-1332629001
I don't find assertion messages referring to negative scale. We only refer max scale in error message while validating scale. So I just update the datatype doc for negative scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org