You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/01/03 02:46:53 UTC
[GitHub] [fineract-cn-command] rverma-jm opened a new pull request #12:
Upstream
rverma-jm opened a new pull request #12: Upstream
URL: https://github.com/apache/fineract-cn-command/pull/12
Bumped mq and support for authentication. Required is we are using Amazon MQ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] awasum merged pull request #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] awasum commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-573178054
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] rverma-jm commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
rverma-jm commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-573175902
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] awasum commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-570776195
Why dont we make securing the MQ optional? such that, if the username and password for activeMQ are available, we use them to set the proper fields. But if the username and password are not in the environment, we dont set the username and password for activeMQ.
What do you all think? Backward compatible and ease testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] awasum commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-573421908
> @awasum I am looking forward to contribute the update of gradle, spring-boot and spring-cloud for our internal usage. Would love to send PR for upstream.
>
> Few additional things I want is to migrate the service discovery and config management to kubernetes native. https://cloud.spring.io/spring-cloud-kubernetes/reference/html/.
>
> Will you accept pull requests for same?
Yes, propose your changes by send a PR. Also sign up to the mailing list and discuss your ideas. It will be great to have contributions from you. https://mifos.org/resources/community/communications/
Introduce yourself when you signup to the Fineract Dev List.
Thanks very much for your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] rverma-jm commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
rverma-jm commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-570475974
@aasaru Can you please review and merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-command] rverma-jm commented on issue #12: Support for
secured MQ
Posted by GitBox <gi...@apache.org>.
rverma-jm commented on issue #12: Support for secured MQ
URL: https://github.com/apache/fineract-cn-command/pull/12#issuecomment-573399472
@awasum I am looking forward to contribute the update of gradle, spring-boot and spring-cloud for our internal usage. Would love to send PR for upstream.
Few additional things I want is to migrate the service discovery and config management to kubernetes native. https://cloud.spring.io/spring-cloud-kubernetes/reference/html/.
Will you accept pull requests for same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services