You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/05/05 08:26:30 UTC
[GitHub] [fluo-muchos] arvindshmicrosoft opened a new pull request #343: Allow switching between side-by-side JDK versions
arvindshmicrosoft opened a new pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343
* Fixes #342 by using 'alternatives' to set the active JDK path
* Update JDK version map to reflect Java 14 as current latest (non-LTS)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #343: Allow switching between side-by-side JDK versions
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343#issuecomment-624769586
Thanks @milleruntime I created #344 to track. I will look into that later this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] milleruntime commented on pull request #343: Allow switching between side-by-side JDK versions
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343#issuecomment-624666406
This looks pretty good. I am still learning muchos and ansible so my feedback is mostly for educational purposes :grin:
I was able to run ```muchos setup``` with Accumulo 2.1 snapshot and java 11. I think something is still wrong as I am seeing this directory not get resolved:
```
[centos@leader1 ~]$ ls
${accumulo.log.dir} ansible install mvn_dep tarballs
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] milleruntime commented on pull request #343: Allow switching between side-by-side JDK versions
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343#issuecomment-624766054
> > @ctubbsii perhaps this is related to updates to Log4j? The only reference i am seeing to "accumulo.log.dir" are in [log4j-service.properties](https://github.com/apache/fluo-muchos/blob/5ca9b8ec7b0a2e50fc22deda0bc10a38b0bfc6dc/ansible/roles/accumulo/templates/log4j-service.properties#L19)
>
> Good catch - looks like we need to update the config files to handle the new log4j2 ones. Since that is orthogonal to this current "JDK switch" issue, I propose we track and fix that separately.
Yeah that is fine, it can be done as a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on pull request #343: Allow switching between side-by-side JDK versions
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343#issuecomment-624761125
> @ctubbsii perhaps this is related to updates to Log4j? The only reference i am seeing to "accumulo.log.dir" are in [log4j-service.properties](https://github.com/apache/fluo-muchos/blob/5ca9b8ec7b0a2e50fc22deda0bc10a38b0bfc6dc/ansible/roles/accumulo/templates/log4j-service.properties#L19)
Good catch - looks like we need to update the config files to handle the new log4j2 ones. Since that is orthogonal to this current "JDK switch" issue, I propose we track and fix that separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] milleruntime commented on pull request #343: Allow switching between side-by-side JDK versions
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #343:
URL: https://github.com/apache/fluo-muchos/pull/343#issuecomment-624728482
@ctubbsii perhaps this is related to updates to Log4j? The only reference i am seeing to "accumulo.log.dir" are in [log4j-service.properties](https://github.com/apache/fluo-muchos/blob/5ca9b8ec7b0a2e50fc22deda0bc10a38b0bfc6dc/ansible/roles/accumulo/templates/log4j-service.properties#L19)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org