[GitHub] [airflow] ramandumcs commented on a change in pull request #5345: AIRFLOW-4594 Pod state might be different from task state. So don't c…

[GitBox <gi...@apache.org>]

ramandumcs commented on a change in pull request #5345: AIRFLOW-4594 Pod state might be different from task state. So don't c…
URL: https://github.com/apache/airflow/pull/5345#discussion_r288951297
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -364,7 +364,7 @@ def process_status(self, pod_id, status, labels, resource_version):
             self.log.info('Event: %s Pending', pod_id)
         elif status == 'Failed':
             self.log.info('Event: %s Failed', pod_id)
-            self.watcher_queue.put((pod_id, State.FAILED, labels, resource_version))
 
 Review comment:
   Thanks @ashb but in such scenarios wouldn't scheduler mark them as zombie and would appropriately update their state like either as failed or up_for_retry etc.
   Currently watcher is updating task state and Scheduler is ignoring them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services