You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sreenath Somarajapuram <ss...@hortonworks.com> on 2016/02/07 16:01:32 UTC
Review Request 43310: Tez Ambari View: Improve host configuration
logic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43310/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
Bugs: AMBARI-14940
https://issues.apache.org/jira/browse/AMBARI-14940
Repository: ambari
Description
-------
- Make selenium tests work for Tez UI.
- Currently host for rm and timeline is obtained from window.location.origin. As the support for origin is limited to modern browsers its better to construct the value from location.protocol, location.hostName & location.port.
Diffs
-----
contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js b45fef0
Diff: https://reviews.apache.org/r/43310/diff/
Testing
-------
- Change was tested in selenium.
- The change was also tested in ambari.
Thanks,
Sreenath Somarajapuram
Re: Review Request 43310: Tez Ambari View: Improve host configuration
logic
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43310/#review118219
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 7, 2016, 3:01 p.m., Sreenath Somarajapuram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43310/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 3:01 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-14940
> https://issues.apache.org/jira/browse/AMBARI-14940
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Make selenium tests work for Tez UI.
> - Currently host for rm and timeline is obtained from window.location.origin. As the support for origin is limited to modern browsers its better to construct the value from location.protocol, location.hostName & location.port.
>
>
> Diffs
> -----
>
> contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js b45fef0
>
> Diff: https://reviews.apache.org/r/43310/diff/
>
>
> Testing
> -------
>
> - Change was tested in selenium.
> - The change was also tested in ambari.
>
>
> Thanks,
>
> Sreenath Somarajapuram
>
>
Re: Review Request 43310: Tez Ambari View: Improve host configuration
logic
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43310/#review118218
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 7, 2016, 3:01 p.m., Sreenath Somarajapuram wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43310/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 3:01 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-14940
> https://issues.apache.org/jira/browse/AMBARI-14940
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Make selenium tests work for Tez UI.
> - Currently host for rm and timeline is obtained from window.location.origin. As the support for origin is limited to modern browsers its better to construct the value from location.protocol, location.hostName & location.port.
>
>
> Diffs
> -----
>
> contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js b45fef0
>
> Diff: https://reviews.apache.org/r/43310/diff/
>
>
> Testing
> -------
>
> - Change was tested in selenium.
> - The change was also tested in ambari.
>
>
> Thanks,
>
> Sreenath Somarajapuram
>
>