You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/04 05:37:26 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41606: [WIP] [SPARK-44061][PYTHON] Add assertDFEqual util function

HyukjinKwon commented on code in PR #41606:
URL: https://github.com/apache/spark/pull/41606#discussion_r1251505670


##########
python/pyspark/testing/utils.py:
##########
@@ -49,6 +60,20 @@
 SPARK_HOME = _find_spark_home()
 
 
+class bcolors:
+    NC = "\033[0m"  # No Color, reset all

Review Comment:
   `no_color`, `light_red` and `light_blue` per PEP 8, and to be consistent.
   Optionally you can put `NO_COLOR`, `LIGHT_RED` and `LIGHT_BLUE` at the module level as a legitimate constant (that complies PEP 8).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org