You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/30 03:37:09 UTC
[GitHub] [incubator-druid] clintropolis commented on issue #8192: fix
circular reference in moving average query
clintropolis commented on issue #8192: fix circular reference in moving average query
URL: https://github.com/apache/incubator-druid/pull/8192#issuecomment-516247182
This appears to partially fix the issue in my testing, at least in terms of the broker being unable to start.
However, there are some additional difficulties to use this extension. The middle-manager is unable to load this extension, it explodes on startup with a similar:
```
Exception in thread "main" java.lang.RuntimeException: com.google.inject.CreationException: Unable to create injector, see the following errors:
1) No implementation for org.apache.druid.query.QuerySegmentWalker was bound.
while locating com.google.inject.Provider<org.apache.druid.query.QuerySegmentWalker>
for the 1st parameter of org.apache.druid.query.movingaverage.MovingAverageQueryToolChest.<init>(MovingAverageQueryToolChest.java:62)
at org.apache.druid.query.movingaverage.MovingAverageQueryModule.configure(MovingAverageQueryModule.java:48) (via modules: com.google.inject.util.Modules$OverrideModule -> org.apache.druid.query.movingaverage.MovingAverageQueryModule)
2) No implementation for org.apache.druid.server.log.RequestLogger was bound.
while locating org.apache.druid.server.log.RequestLogger
for the 2nd parameter of org.apache.druid.query.movingaverage.MovingAverageQueryToolChest.<init>(MovingAverageQueryToolChest.java:62)
at org.apache.druid.query.movingaverage.MovingAverageQueryModule.configure(MovingAverageQueryModule.java:48) (via modules: com.google.inject.util.Modules$OverrideModule -> org.apache.druid.query.movingaverage.MovingAverageQueryModule)
```
so `druid.indexer.fork.property.druid.extensions.loadList` must be set to allow the peons to load a different set of extensions than the middle-manager, which isn't so big of a deal imo. The peon tasks for kafka indexing service did appear to startup and load the extension correctly when I did this.
More problematic, is the router, which is also unable to load this extension:
```
Exception in thread "main" java.lang.RuntimeException: com.google.inject.CreationException: Unable to create injector, see the following errors:
1) No implementation for org.apache.druid.query.QuerySegmentWalker was bound.
while locating com.google.inject.Provider<org.apache.druid.query.QuerySegmentWalker>
for the 1st parameter of org.apache.druid.query.movingaverage.MovingAverageQueryToolChest.<init>(MovingAverageQueryToolChest.java:62)
at org.apache.druid.query.movingaverage.MovingAverageQueryModule.configure(MovingAverageQueryModule.java:48) (via modules: com.google.inject.util.Modules$OverrideModule -> org.apache.druid.query.movingaverage.MovingAverageQueryModule)
```
because without the extension loaded, the router is unable to perform serde on the query making any queries that use this extension unable to use the router if it's not loaded:
<img width="768" alt="Screen Shot 2019-07-29 at 8 24 52 PM" src="https://user-images.githubusercontent.com/1577461/62098664-27639700-b240-11e9-884e-893ebf70dccc.png">
I'm unsure how to resolve this situation, i guess the router could inject null as a segment walker since none of this stuff will be called, it just needs the types to do serde, but that also seems sort of lame? Not sure what is best to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org