[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #683: refactor(c/driver/postgresql): Implement InputIterator for ResultHelper

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #683:
URL: https://github.com/apache/arrow-adbc/pull/683#discussion_r1195669887


##########
c/driver/postgresql/connection.cc:
##########
@@ -170,13 +241,10 @@ AdbcStatusCode PostgresConnectionGetObjectsImpl(
 
     PqResultHelper result_helper = PqResultHelper{conn, query.buffer};
     StringBuilderReset(&query);
-    pg_result* result = result_helper.Execute();
 
-    ExecStatusType pq_status = PQresultStatus(result);
-    if (pq_status == PGRES_TUPLES_OK) {
-      int num_rows = PQntuples(result);
-      for (int row = 0; row < num_rows; row++) {
-        const char* db_name = PQgetvalue(result, row, 0);
+    if (result_helper.Status() == PGRES_TUPLES_OK) {

Review Comment:
   I don't think the diff makes it very clear but this returns `ADBC_STATUS_NOT_IMPLEMENTED` when this condition is not satisified (already in existing code)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org