You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Tom Clarkson (JIRA)" <ji...@apache.org> on 2012/09/07 15:43:07 UTC
[jira] [Created] (CB-1387) Splash screens broken due to error in
iPad detection code
Tom Clarkson created CB-1387:
--------------------------------
Summary: Splash screens broken due to error in iPad detection code
Key: CB-1387
URL: https://issues.apache.org/jira/browse/CB-1387
Project: Apache Cordova
Issue Type: Bug
Components: iOS
Affects Versions: 2.1.0
Reporter: Tom Clarkson
Assignee: Shazron Abdullah
The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450813#comment-13450813 ]
Michal Mocny commented on CB-1387:
----------------------------------
Updated my branch with the rename suggestion, pull request seemed to automatically update (branch based, or specific revision based, it seems).
Is it worthwhile updating IsAtLeastiOSVersion as well?
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450769#comment-13450769 ]
Andrew Grieve commented on CB-1387:
-----------------------------------
When did you add this macro? I think it should be namespaced since it appears in a public header. e.g. CDV_IsIPad()
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450621#comment-13450621 ]
Michal Mocny commented on CB-1387:
----------------------------------
I'll take a look, I added the offending macro.
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Grieve closed CB-1387.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
fixes committed.
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=log;h=HEAD
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
> Fix For: 2.1.0
>
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450809#comment-13450809 ]
Michal Mocny commented on CB-1387:
----------------------------------
Possibly you are right, but I was following the convention of the above IsAtLeastiOSVersion macro. IsIPad does certainly have higher odds of collision, though.
Macro was added as part of the orientation fix (pull request linked above):
commit d8575d7eece28ec2c90de4b448af729accaf2567
Author: Michal Mocny <mm...@gmail.com>
Date: Wed Aug 29 10:53:59 2012 -0400
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450642#comment-13450642 ]
Michal Mocny commented on CB-1387:
----------------------------------
https://github.com/apache/incubator-cordova-ios/pull/47 seems to fix the issue (verified via manual tests, and by not seeing the splash screen error logging any more).
The fix was originally suggested in the patch that added the macro.
Does this affect 2.1 release?
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-1387) Splash screens broken due to error in
iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michal Mocny reassigned CB-1387:
--------------------------------
Assignee: Michal Mocny (was: Shazron Abdullah)
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-1387) Splash screens broken due to
error in iPad detection code
Posted by "Michal Mocny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450813#comment-13450813 ]
Michal Mocny edited comment on CB-1387 at 9/8/12 4:31 AM:
----------------------------------------------------------
Updated my branch with the rename suggestion, pull request seemed to automatically update (pull is branch based rather than specific revision based, it seems).
Is it worthwhile updating IsAtLeastiOSVersion as well?
was (Author: mmocny):
Updated my branch with the rename suggestion, pull request seemed to automatically update (branch based, or specific revision based, it seems).
Is it worthwhile updating IsAtLeastiOSVersion as well?
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
> Key: CB-1387
> URL: https://issues.apache.org/jira/browse/CB-1387
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Affects Versions: 2.1.0
> Reporter: Tom Clarkson
> Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from finding the correct images.
> The issue appears to be load order - #ifdef UI_USER_INTERFACE_IDIOM returns false in CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira