You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/04 13:49:51 UTC

[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1894: refactor-logger branch view log CommandType modify

qiaozhanwei opened a new pull request #1894: refactor-logger branch view log CommandType modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1894
 
 
   refactor-logger branch view log CommandType modify

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1894: refactor-logger branch view log CommandType modify

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1894: refactor-logger branch view log CommandType modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1894#issuecomment-581921221
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=h1) Report
   > Merging [#1894](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=desc) into [refactor-logger](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/2652b259f837ba54be2e553c2320575627851e68?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=tree)
   
   ```diff
   @@               Coverage Diff                @@
   ##           refactor-logger    #1894   +/-   ##
   ================================================
     Coverage            19.62%   19.62%           
   ================================================
     Files                  314      314           
     Lines                14510    14510           
     Branches              2421     2421           
   ================================================
     Hits                  2847     2847           
   + Misses               11338    11337    -1     
   - Partials               325      326    +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...remote/command/log/RollViewLogResponseCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvbG9nL1JvbGxWaWV3TG9nUmVzcG9uc2VDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...uler/remote/command/log/GetLogResponseCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvbG9nL0dldExvZ1Jlc3BvbnNlQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=footer). Last update [2652b25...992d0a6](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1894: refactor-logger branch view log CommandType modify

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1894: refactor-logger branch view log CommandType modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1894#issuecomment-581923353
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1894&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1894&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1894&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1894&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1894&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1894: refactor-logger branch view log CommandType modify

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1894: refactor-logger branch view log CommandType modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1894#issuecomment-581921221
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=h1) Report
   > Merging [#1894](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=desc) into [refactor-logger](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/2652b259f837ba54be2e553c2320575627851e68?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=tree)
   
   ```diff
   @@               Coverage Diff                @@
   ##           refactor-logger    #1894   +/-   ##
   ================================================
     Coverage            19.62%   19.62%           
   ================================================
     Files                  314      314           
     Lines                14510    14510           
     Branches              2421     2421           
   ================================================
     Hits                  2847     2847           
   + Misses               11338    11337    -1     
   - Partials               325      326    +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...remote/command/log/RollViewLogResponseCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvbG9nL1JvbGxWaWV3TG9nUmVzcG9uc2VDb21tYW5kLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...uler/remote/command/log/GetLogResponseCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2NvbW1hbmQvbG9nL0dldExvZ1Jlc3BvbnNlQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=footer). Last update [2652b25...992d0a6](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1894: refactor-logger branch view log CommandType modify

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1894: refactor-logger branch view log CommandType modify
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1894
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services