You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/09/13 02:00:59 UTC
[jira] [Comment Edited] (THRIFT-2069) TPipeServer creates
overlapped pipes, then uses synchronous I/O on them with TPipe
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765848#comment-13765848 ]
Jens Geyer edited comment on THRIFT-2069 at 9/12/13 11:59 PM:
--------------------------------------------------------------
+1
Looks good to me, and it is for sure an improvement compared to the previous code. However, I have to admit that I did not test it very deeply. I'll see how I can improve the Delphi version based on your stuff, there are quite a few good ideas in there.
was (Author: jensg):
+1
Looks good to me, and it is for sure an improvement compared to the previous code. However, I have to admit that I did not test it very deeply. I'll see how I can improve the Delphi version based on your stuff, there are quite a few good ideas in there.
> TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe
> ----------------------------------------------------------------------------------
>
> Key: THRIFT-2069
> URL: https://issues.apache.org/jira/browse/THRIFT-2069
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 1.0
> Environment: Windows
> Reporter: Ben Craig
> Assignee: Ben Craig
> Fix For: 1.0
>
> Attachments: overlapped_pipes.patch
>
>
> The documentation for ReadFile states the following:
> A pointer to an OVERLAPPED structure is required if the hFile parameter was opened with FILE_FLAG_OVERLAPPED, otherwise it can be NULL.
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365467%28v=vs.85%29.aspx
> In C++'s TPipeServer, we create a named pipe with FILE_FLAG_OVERLAPPED, then create a TPipe with it. TPipe then calls ReadFile without an overlapped structure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira