You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/22 04:16:16 UTC
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1424: Share jars between server and beeline to reduce binary size
pan3793 commented on a change in pull request #1424:
URL: https://github.com/apache/incubator-kyuubi/pull/1424#discussion_r753934559
##########
File path: build/dist
##########
@@ -192,6 +192,14 @@ cp -r "$KYUUBI_HOME/kyuubi-assembly/target/scala-$SCALA_VERSION/jars/" "$DISTDIR
# Copy kyuubi beeline jars
cp "$KYUUBI_HOME"/kyuubi-hive-beeline/target/*.jar "$DISTDIR/beeline-jars/"
+# Share the jars between server and beeline to reduce binary size
+for jar in $(ls "$DISTDIR/jars/"); do
+ if [[ -f "$DISTDIR/beeline-jars/$jar" ]]; then
+ rm "$DISTDIR/beeline-jars/$jar"
+ ln -sn "$DISTDIR/jars/$jar" "$DISTDIR/beeline-jars/$jar"
Review comment:
Does the absolute path work if user untar to another folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org