You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Barrie Treloar <ba...@gmail.com> on 2009/03/31 01:19:41 UTC

Re: svn commit: r759846 - in /maven/plugins/trunk/maven-eclipse-plugin: ./ src/main/java/org/apache/maven/plugin/eclipse/ src/test/java/org/apache/maven/plugin/eclipse/ src/test/java/org/apache/maven/plugin/eclipse/it/ src/test/resources/projects/pro

On Tue, Mar 31, 2009 at 4:36 AM, Benjamin Bentmann
<be...@udo.edu> wrote:
> Hi Barrie,
>
>> Author: baerrach
>> Date: Mon Mar 30 06:26:34 2009
>> New Revision: 759846
>>
>> URL: http://svn.apache.org/viewvc?rev=759846&view=rev
>> Log:
>> [MECLIPSE-104] - Add the ability to specify source inclusions/exclusions
>> Submitted by: Richard van der Hoff
>>
>> The configuration for EclipsePlugin now accepts <sourceInclusions>
>>  <sourceInclusion>XXX</sourceInclusion>
>> <sourceInclusions>
>> (same for sourceExclusions)
>>
>> to modifiy the classpath entries for source directories.
>>
>> **/*.java is always added if it is a java (or pde) project
>> **/*.aj is always added if it is an ajdt project.
>>
>> Modified: maven/plugins/trunk/maven-eclipse-plugin/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/pom.xml?rev=759846&r1=759845&r2=759846&view=diff
>>
>> ==============================================================================
>> --- maven/plugins/trunk/maven-eclipse-plugin/pom.xml (original)
>> +++ maven/plugins/trunk/maven-eclipse-plugin/pom.xml Mon Mar 30 06:26:34
>> 2009
>> @@ -27,7 +27,7 @@
>>     <version>13</version>
>>   </parent>
>>   <artifactId>maven-eclipse-plugin</artifactId>
>> -  <version>2.7-SNAPSHOT</version>
>> +  <version>2.6.1-SNAPSHOT</version>
>
> Given this is a new feature, wouldn't version 2.7 be more appropriate for
> the next release?

Kind of.

MECLIPSE-538 "Ajdt support needs to include*.aj on the classpath"
broke because MECLIPSE-443 "Only include **/*.java in Java source
directories" (released in 2.6) because it started adding
including/excluding to classpaths where before this was empty and
therefore anything in these paths would be located. Essentially
breaking ajdt use.

The fix for ajdt was so similar to MECLIPSE-538 (and made a better
generic fix) that I also pushed that in there.

I dont have a problem with upping the revision number though.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r759846 - in /maven/plugins/trunk/maven-eclipse-plugin: ./ src/main/java/org/apache/maven/plugin/eclipse/ src/test/java/org/apache/maven/plugin/eclipse/ src/test/java/org/apache/maven/plugin/eclipse/it/ src/test/resources/projects/pro

Posted by Barrie Treloar <ba...@gmail.com>.
>> Given this is a new feature, wouldn't version 2.7 be more appropriate for
>> the next release?

Changed back to 2.7.
(Issues in 2.7 bumped to 2.8)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org