You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/15 17:35:53 UTC

[GitHub] [beam] ibzib commented on a change in pull request #14988: [BEAM-8137] Refactor External Worker Service to be part of sdks-java-harness

ibzib commented on a change in pull request #14988:
URL: https://github.com/apache/beam/pull/14988#discussion_r652007682



##########
File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/FnService.java
##########
@@ -15,7 +15,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.beam.runners.fnexecution;
+package org.apache.beam.sdk.fn;

Review comment:
       Instead of moving classes to `org.apache.beam.sdk.fn`, can we create a new subpackage, such as `org.apache.beam.sdk.fn.server`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org