You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2015/02/24 18:43:02 UTC
Review Request 31363: Patch for kafka-1984
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31363/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1984
https://issues.apache.org/jira/browse/kafka-1984
Repository: kafka
Description
-------
minor renaming
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 8112e6d89df784af2877b830062072a308e5370c
clients/src/main/java/org/apache/kafka/common/Cluster.java 8fcd2916f1d557e2df5450436d7e41d01db99cd9
clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java 29c8417422c0cf0d29bf2405c77fd05e35350259
Diff: https://reviews.apache.org/r/31363/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 31363: Patch for kafka-1984
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31363/#review73918
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On Feb. 24, 2015, 5:43 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31363/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 5:43 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1984
> https://issues.apache.org/jira/browse/kafka-1984
>
>
> Repository: kafka
>
>
> Description
> -------
>
> minor renaming
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 8112e6d89df784af2877b830062072a308e5370c
> clients/src/main/java/org/apache/kafka/common/Cluster.java 8fcd2916f1d557e2df5450436d7e41d01db99cd9
> clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java 29c8417422c0cf0d29bf2405c77fd05e35350259
>
> Diff: https://reviews.apache.org/r/31363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 31363: Patch for kafka-1984
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31363/#review73840
-----------------------------------------------------------
Ship it!
Minor nit, but LGTM.
clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java
<https://reviews.apache.org/r/31363/#comment120248>
A note about why this is out of order might be a good idea. Otherwise someone is bound to reorder it and the test will no longer check that the partition # is returned instead of the index.
- Ewen Cheslack-Postava
On Feb. 24, 2015, 5:43 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31363/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 5:43 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1984
> https://issues.apache.org/jira/browse/kafka-1984
>
>
> Repository: kafka
>
>
> Description
> -------
>
> minor renaming
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 8112e6d89df784af2877b830062072a308e5370c
> clients/src/main/java/org/apache/kafka/common/Cluster.java 8fcd2916f1d557e2df5450436d7e41d01db99cd9
> clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java 29c8417422c0cf0d29bf2405c77fd05e35350259
>
> Diff: https://reviews.apache.org/r/31363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>