You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2012/10/18 06:52:03 UTC

[jira] [Created] (FELIX-3718) [DS] deactivate might not move component state to unsatisfied

David Jencks created FELIX-3718:
-----------------------------------

             Summary: [DS] deactivate might not move component state to unsatisfied
                 Key: FELIX-3718
                 URL: https://issues.apache.org/jira/browse/FELIX-3718
             Project: Felix
          Issue Type: Bug
          Components: Declarative Services (SCR)
    Affects Versions: scr-1.8.0
            Reporter: David Jencks
            Assignee: David Jencks
             Fix For: scr-1.8.0


After deactivating, we check to see if the state changed before moving to unsatisfied:

            if ( acm.state() == this )
            {
                acm.changeState( Unsatisfied.getInstance() );
            }


But the state might have been moved from Active to Registered meanwhile, so deactivate would leave us in the Registered state.  Instead, check if the state is a satisfied state, and if so, move it to unsatisfied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3718) [DS] deactivate might not move component state to unsatisfied

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated FELIX-3718:
-------------------------------------

    Fix Version/s:     (was: scr-1.8.0)
                   scr-1.6.2
    
> [DS] deactivate might not move component state to unsatisfied
> -------------------------------------------------------------
>
>                 Key: FELIX-3718
>                 URL: https://issues.apache.org/jira/browse/FELIX-3718
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.6.2
>
>
> After deactivating, we check to see if the state changed before moving to unsatisfied:
>             if ( acm.state() == this )
>             {
>                 acm.changeState( Unsatisfied.getInstance() );
>             }
> But the state might have been moved from Active to Registered meanwhile, so deactivate would leave us in the Registered state.  Instead, check if the state is a satisfied state, and if so, move it to unsatisfied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (FELIX-3718) [DS] deactivate might not move component state to unsatisfied

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks resolved FELIX-3718.
---------------------------------

    Resolution: Fixed

rev 1399525.  I introduced an isSatisfied method on State so if we are still in a satisfied state at the end of deactivation, we move to unsatisfied.
                
> [DS] deactivate might not move component state to unsatisfied
> -------------------------------------------------------------
>
>                 Key: FELIX-3718
>                 URL: https://issues.apache.org/jira/browse/FELIX-3718
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.8.0
>
>
> After deactivating, we check to see if the state changed before moving to unsatisfied:
>             if ( acm.state() == this )
>             {
>                 acm.changeState( Unsatisfied.getInstance() );
>             }
> But the state might have been moved from Active to Registered meanwhile, so deactivate would leave us in the Registered state.  Instead, check if the state is a satisfied state, and if so, move it to unsatisfied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (FELIX-3718) [DS] deactivate might not move component state to unsatisfied

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed FELIX-3718.
------------------------------------


Close after release
                
> [DS] deactivate might not move component state to unsatisfied
> -------------------------------------------------------------
>
>                 Key: FELIX-3718
>                 URL: https://issues.apache.org/jira/browse/FELIX-3718
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.6.2
>
>
> After deactivating, we check to see if the state changed before moving to unsatisfied:
>             if ( acm.state() == this )
>             {
>                 acm.changeState( Unsatisfied.getInstance() );
>             }
> But the state might have been moved from Active to Registered meanwhile, so deactivate would leave us in the Registered state.  Instead, check if the state is a satisfied state, and if so, move it to unsatisfied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira