[GitHub] [superset] villebro commented on pull request #20627: fix(chart): Time Series set showMaxLabel as null for time xAxis

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on PR #20627:
URL: https://github.com/apache/superset/pull/20627#issuecomment-1436684100

   @Antonio-RiveroMartnez I've noticed that this PR has caused time series charts to show weird max labels when the chart is wide enough:
   <img width="327" alt="image" src="https://user-images.githubusercontent.com/33317356/220075819-5138e64c-e076-484f-916e-c04c9ed07054.png">
   
   Removing `showMaxLabel: null` resolves it: 
   <img width="403" alt="image" src="https://user-images.githubusercontent.com/33317356/220075965-b070e0d8-5564-4e67-be06-708c1024460d.png">
   
   IIRC, setting `showMaxLabel: null` makes it behave the same as if it was set to `showMaxLabel: true`. Therefore, I believe we should revert this change and consider alternative solutions for solving the problem this initially tried to fix.
   
   Ping also reviewers @rusackas and @diegomedina248 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org