[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[bhaisaab <gi...@git.apache.org>]

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1140#discussion_r46256253
  
    --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ---
    @@ -685,6 +685,16 @@ public void finalizeStop(final VirtualMachineProfile profile, final Answer answe
         }
     
         @Override
    +    public boolean start() {
    +        return true;
    --- End diff --
    
    @harikrishna-patnala Hi Hari, can you explain what the changes are doing to fix the issue of multiple thread synchronisation ? Also, what happens across multiple mgmt servers since we don't have any distributed consensus implementation in place, I suppose the statcollector values might be different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---