You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/09 22:35:01 UTC
[GitHub] [beam] benWize opened a new pull request, #23167: GA migration Postcommit XVR
benWize opened a new pull request, #23167:
URL: https://github.com/apache/beam/pull/23167
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
- Migrated workflow [job-postcommit-pythonusingjavasql-dataflow.yml](https://github.com/benWize/beam/blob/9cc7af8eb25865d25e7bfaed947efecca8b44415/.github/workflows/job-postcommit-pythonusingjavasql-dataflow.yml)
- Migrated workflow [job-postcommit-xvr-samza.yml](https://github.com/benWize/beam/blob/9cc7af8eb25865d25e7bfaed947efecca8b44415/.github/workflows/job-postcommit-xvr-samza.yml)
- Migrated workflow [job-postcommit-xvr-spark.yml](https://github.com/benWize/beam/blob/9cc7af8eb25865d25e7bfaed947efecca8b44415/.github/workflows/job-postcommit-xvr-spark.yml)
The migrated workflows were removed from [.test-infra/jenkins/README.md](https://github.com/benWize/beam/blob/9cc7af8eb25865d25e7bfaed947efecca8b44415/.test-infra/jenkins/README.md) and added to [CI.md](https://github.com/benWize/beam/blob/9cc7af8eb25865d25e7bfaed947efecca8b44415/CI.md)
**DO NOT MERGE** until the effort to use **self-hosted runners** is completed https://github.com/apache/beam/pull/22703
These workflows use base actions listed in https://github.com/apache/beam/pull/23109 (Dependency)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1356229370
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23167: GA migration Postcommit XVR
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1435979607
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on a diff in pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on code in PR #23167:
URL: https://github.com/apache/beam/pull/23167#discussion_r981515326
##########
CI.md:
##########
@@ -125,6 +125,24 @@ Service Account shall have following permissions ([IAM roles](https://cloud.goog
| Java Wordcount Direct Runner | Runs Java WordCount example with Direct Runner. | Yes | Yes | Yes | - |
| Java Wordcount Dataflow | Runs Java WordCount example with DataFlow Runner. | - | Yes | Yes | Yes |
+### PostCommit Workflows
+
+#### XVR Spark - [job-postcommit-xvr-spark.yml](.github/workflows/job-postcommit-xvr-spark.yml)
Review Comment:
Yes, changed it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1243994576
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1259814134
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1256459436
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23167:
URL: https://github.com/apache/beam/pull/23167#discussion_r979453404
##########
CI.md:
##########
@@ -125,6 +125,24 @@ Service Account shall have following permissions ([IAM roles](https://cloud.goog
| Java Wordcount Direct Runner | Runs Java WordCount example with Direct Runner. | Yes | Yes | Yes | - |
| Java Wordcount Dataflow | Runs Java WordCount example with DataFlow Runner. | - | Yes | Yes | Yes |
+### PostCommit Workflows
+
+#### XVR Spark - [job-postcommit-xvr-spark.yml](.github/workflows/job-postcommit-xvr-spark.yml)
Review Comment:
Rather than having a bunch of distinct sections can we just make one larger table? I don't think each of these sections add much
(added same comment in other PRs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1254253165
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1256576278
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1242533614
Successful executions on self-hosted runners:
- Spark XVR: https://github.com/benWize/beam/runs/8279048721?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1243942568
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23167: GA migration Postcommit XVR
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23167:
URL: https://github.com/apache/beam/pull/23167#issuecomment-1244542108
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23167: GA migration Postcommit XVR
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23167: GA migration Postcommit XVR
URL: https://github.com/apache/beam/pull/23167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org