You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 03:52:17 UTC
[GitHub] [airflow] ashb opened a new pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
ashb opened a new pull request #18797:
URL: https://github.com/apache/airflow/pull/18797
Previously we pinned this version as v12 as a change to Kube library
internals meant v1.Pod objects now have a logger object inside them, and
couldn't be pickled on Python 3.6.
To fix that we have "backported" the change in Python 3.7 to make Logger
objects be pickled "by name". (In Python 3.7 the change adds
`__reduce__` methods on to the Logger and RootLogger objects, but here
we achieve it `copyreg` stdlib module so we don't monkeypatch
anything.)
This fix is also applied in to airflow core in a separate commit, but we
also apply it here in the provider so that cncf.kubernetes client
library can be updated but still used with older versions of Airflow
that don't have this fix in.
I think we should *NOT* merge this until after 2.2.0 RC is cut, as I don't think we have time to test the kube client upgrade doesn't break anything before the planned RC release.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#discussion_r748212235
##########
File path: tests/kubernetes/test_client.py
##########
@@ -63,5 +63,9 @@ def test_disable_verify_ssl(self):
_disable_verify_ssl()
- configuration = Configuration()
+ # Support wide range of kube client libraries
+ if hasattr(Configuration, 'get_default_copy'):
+ configuration = Configuration.get_default_copy()
+ else:
+ configuration = Configuration()
Review comment:
```suggestion
try:
configuration = Configuration.get_default_copy()
except AttributeError:
configuration = Configuration()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-967040879
Green enough. Merging to mainline for 2.3 -- we shouldn't pull this in to 2.2 series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-967041122
Oh wait, the helm tests were cancelled. Those one's probably are important to run. 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-937626723
Split the copyreg in core airflow in to https://github.com/apache/airflow/pull/18798 which is fine to merge in for 2.2.0rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18797:
URL: https://github.com/apache/airflow/pull/18797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-1001805744
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-1004749650
Better now after a rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-937619976
> Maybe it is worth splitting this in two actually -- add the reducer for logging to core, but leave the Kube client library version unchanged?
Yeah 2 PRs does make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-937618920
Maybe it is worth splitting this in two actually -- add the reducer for logging to core, but leave the Kube client library version unchanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-941034349
Merging now 2.2.0 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-1004030206
Hmmm helm tests are still timing out here, which means something is not right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #18797:
URL: https://github.com/apache/airflow/pull/18797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#discussion_r748212235
##########
File path: tests/kubernetes/test_client.py
##########
@@ -63,5 +63,9 @@ def test_disable_verify_ssl(self):
_disable_verify_ssl()
- configuration = Configuration()
+ # Support wide range of kube client libraries
+ if hasattr(Configuration, 'get_default_copy'):
+ configuration = Configuration.get_default_copy()
+ else:
+ configuration = Configuration()
Review comment:
```suggestion
# Support wide range of kube client libraries
try:
configuration = Configuration.get_default_copy()
except AttributeError:
configuration = Configuration()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-941034692
Wait -- making sure tests actually run first 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-1014313398
Removing 2.3.0 milestone as this PR is in the provider release cycle.
Was released in `apache-airflow-providers-cncf-kubernetes` version 3.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-937619976
> Maybe it is worth splitting this in two actually -- add the reducer for logging to core, but leave the Kube client library version unchanged?
Yeah 2 PRs does make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18797:
URL: https://github.com/apache/airflow/pull/18797#issuecomment-937618920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org