[GitHub] [incubator-superset] thunter009 commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart

[GitBox <gi...@apache.org>]

thunter009 commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart
URL: https://github.com/apache/incubator-superset/pull/8082#issuecomment-528550812
 
 
   I incorporated the logic into the existing JSON `line_type` so as to not add additional complexity to the `viz.py` file as I recall there is an effort to slowly remove code from this file. Is that not correct?
   
   As is, this PR handles mixed GeoJSON polygon types (Polygon + MultiPolygon) dynamically and will determine the type of GeoJSON polygon before processing it. Any other GeoJSON types will simply not render -- I've tested Point, MultiPoint, LineString, and MultiLineString data to prove this out. Perhaps an error message pointing users to the GeoJSON chart type would be helpful if a user is trying to render Point/MultiPoint/LineString data in the polygon chart?
   
   I also tested `null` geometry values and they do not render as well. I will work on adding error handling for those as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org