o.a.c.ha.session.BackupManager question

[Ian Darwin <ia...@darwinsys.com>]

While running an automated code testing tool of my own design I found 
that a few of the accessors on this class are incorrect, or at least,

   "setter silently ignored, getter returns hard-coded value".

Can anybody please tell me if this was intentional, or just something that's
not used anyway? The methods come from the ClusterManager Interface, if that helps.

If it's intentional should we at least stick in a comment?

Thanks
Ian

>    public void messageDataReceived(ClusterMessage msg) {
>    }
> 
>    public boolean doDomainReplication() {
>        return false;
>    }
> 
>    /**
>     * @param sendClusterDomainOnly The sendClusterDomainOnly to set.
>     */
>    public void setDomainReplication(boolean sendClusterDomainOnly) {
>    }
> 
>    /**
>     * @return Returns the defaultMode.
>     */
>    public boolean isDefaultMode() {
>        return false;
>    }
>    /**
>     * @param defaultMode The defaultMode to set.
>     */
>    public void setDefaultMode(boolean defaultMode) {
>    }
> 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: o.a.c.ha.session.BackupManager question

[Filip Hanik - Dev Lists <de...@hanik.com>]

The methods on the interface are custom to a specific implementation. 
And the backup manager for example, doesn't need these, nor does it use them

So not entirely intentional, just legacy that lives on.

Filip

Ian Darwin wrote:
> While running an automated code testing tool of my own design I found 
> that a few of the accessors on this class are incorrect, or at least,
>
>   "setter silently ignored, getter returns hard-coded value".
>
> Can anybody please tell me if this was intentional, or just something 
> that's
> not used anyway? The methods come from the ClusterManager Interface, 
> if that helps.
>
> If it's intentional should we at least stick in a comment?
>
> Thanks
> Ian
>
>>    public void messageDataReceived(ClusterMessage msg) {
>>    }
>>
>>    public boolean doDomainReplication() {
>>        return false;
>>    }
>>
>>    /**
>>     * @param sendClusterDomainOnly The sendClusterDomainOnly to set.
>>     */
>>    public void setDomainReplication(boolean sendClusterDomainOnly) {
>>    }
>>
>>    /**
>>     * @return Returns the defaultMode.
>>     */
>>    public boolean isDefaultMode() {
>>        return false;
>>    }
>>    /**
>>     * @param defaultMode The defaultMode to set.
>>     */
>>    public void setDefaultMode(boolean defaultMode) {
>>    }
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org