[jira] [Commented] (HBASE-11016) Remove Filter#filterRow(List)

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005540#comment-14005540 ] 

Enis Soztutar commented on HBASE-11016:
---------------------------------------

+1 for the patch for trunk. We should do HBASE-10596 as well. My only concern is that if a Filter implemented this method, and does not have {{@Override}} annotation, it will silently work, but not do the filtering which will be a surprising behavior. 

> Remove Filter#filterRow(List)
> -----------------------------
>
>                 Key: HBASE-11016
>                 URL: https://issues.apache.org/jira/browse/HBASE-11016
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>             Fix For: 0.99.0
>
>         Attachments: 11016-v1.txt
>
>
> 0.96+ the filterRow(List) method is deprecated:
> {code}
>    * WARNING: please to not override this method.  Instead override {@link #filterRowCells(List)}.
>    * This is for transition from 0.94 -> 0.96
>    **/
>   @Deprecated
>   abstract public void filterRow(List<KeyValue> kvs) throws IOException;
> {code}
> This method should be removed from Filter classes for 1.0



--
This message was sent by Atlassian JIRA
(v6.2#6252)