[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2253: [CALCITE-4385] Simplifies AND/OR condition that has common expressions, extract and eliminate/merge them as much as possible (Jiatao Tao)

[GitBox <gi...@apache.org>]

Aaaaaaron edited a comment on pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#issuecomment-724407062


   > I have a bad feeling about this change. It adds a lot of new code and does not leverage existing code (e.g. reasoning based on predicates). It is going to be a nightmare to maintain.
   
   Hi, @julianhyde, what do you mean "does not leverage existing code(e.g. reasoning based on predicates)"? Current I just add a utility to simplifies AND/OR condition that has common expressions, it belongs to CALCITE_4375, and later we can think to add this logic to RexSimplify's main process or just used to simplify the join condtition.
   
   In fact, the code is not so much, the real code is no more than 20 lines and there's UT to guarantee this logic.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org