You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/03 22:11:39 UTC
[GitHub] [incubator-mxnet] TristonC opened a new pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
TristonC opened a new pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484
## Description ##
This PR fixes issue [17858](https://github.com/apache/incubator-mxnet/issues/17858).
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Correct current LibraryInitializer::get_sym API. const char* is used instead of char* for the name parameter.
- [x] Correct current get_func API accordingly with const char* instead of char* for the name parameter.
- [x] Call get_sym for all functions from libcuda (functions starting with cu) to dynamically load the symbol and convert them to corresponding function pointers for the src/common/cuda/rtc.cc file.
## Comments ##
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892365376
@mxnet-bot run ci edge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892365604
Jenkins CI successfully triggered : [edge]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892200300
Hey @TristonC , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, centos-gpu, miscellaneous, unix-gpu, website, sanity, windows-cpu, clang, windows-gpu, edge, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892379833
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892379864
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892988931
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892882034
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892774851
@mxnet-bot run ci [centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC edited a comment on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC edited a comment on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892201126
@ptrendx @leezu @szha Please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892988972
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892881970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892774940
Jenkins CI successfully triggered : [unix-gpu, centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892365403
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892774851
@mxnet-bot run ci [centos-gpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892881970
@mseth10 The failed centos-gpu test seems flaky.
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC edited a comment on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC edited a comment on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892365376
@mxnet-bot run ci [edge]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
TristonC commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892201126
@ptrendx @leezu Please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20484: [FEATURE] Load libcuda with dlopen instead of dynamic linking
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20484:
URL: https://github.com/apache/incubator-mxnet/pull/20484#issuecomment-892774940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org