You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/07/26 13:43:05 UTC

Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/
-----------------------------------------------------------

Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Bugs: Cloudstack-1640


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-1640
overcommited memory is not getting displayed at zone level and used % is based on actual memory


Diffs
-----

  server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 

Diff: https://reviews.apache.org/r/12966/diff/


Testing
-------

Tested on older master.
deployed vms and checked the capacites displayed on the dashboard.


Thanks,

bharat kumar


Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/#review24248
-----------------------------------------------------------

Ship it!


commit 6e9bf56cf195f990cf4b37556d0f5e796de2238a

- Kishan Kavala


On July 30, 2013, 7:41 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12966/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 7:41 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-1640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1640
> overcommited memory is not getting displayed at zone level and used % is based on actual memory
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java dc2899f 
>   server/src/com/cloud/alert/AlertManagerImpl.java bff36c7 
>   server/src/com/cloud/api/ApiResponseHelper.java f7b740b 
>   server/src/com/cloud/server/ManagementServerImpl.java 0bdb114 
> 
> Diff: https://reviews.apache.org/r/12966/diff/
> 
> 
> Testing
> -------
> 
> Tested on older master.
> deployed vms and checked the capacites displayed on the dashboard.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/
-----------------------------------------------------------

(Updated July 30, 2013, 2:11 p.m.)


Review request for cloudstack, Kishan Kavala and Nitin Mehta.


Changes
-------

uploaded the correct file.


Bugs: Cloudstack-1640


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-1640
overcommited memory is not getting displayed at zone level and used % is based on actual memory


Diffs (updated)
-----

  engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java dc2899f 
  server/src/com/cloud/alert/AlertManagerImpl.java bff36c7 
  server/src/com/cloud/api/ApiResponseHelper.java f7b740b 
  server/src/com/cloud/server/ManagementServerImpl.java 0bdb114 

Diff: https://reviews.apache.org/r/12966/diff/


Testing
-------

Tested on older master.
deployed vms and checked the capacites displayed on the dashboard.


Thanks,

bharat kumar


Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12966/#review23947
-----------------------------------------------------------


Review 12966 PASSED the build test
The url of build cloudstack-master-with-patch #49 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/49/

- Jenkins Cloudstack.org


On July 26, 2013, 11:43 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12966/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 11:43 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
> 
> 
> Bugs: Cloudstack-1640
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1640
> overcommited memory is not getting displayed at zone level and used % is based on actual memory
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
> 
> Diff: https://reviews.apache.org/r/12966/diff/
> 
> 
> Testing
> -------
> 
> Tested on older master.
> deployed vms and checked the capacites displayed on the dashboard.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>