You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/27 12:32:07 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2756: nrf52: add stackcheck support

v01d opened a new pull request #2756:
URL: https://github.com/apache/incubator-nuttx/pull/2756


   ## Summary
   
   Add required code to support stack checking functionality.
   
   ## Impact
   
   Add feature
   
   ## Testing
   
   Built OK, can't verify if it is working though.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2756: nrf52: add stackcheck support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2756:
URL: https://github.com/apache/incubator-nuttx/pull/2756


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2756: nrf52: add stackcheck support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2756:
URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768259611


   > This requires the appropriate build flag (-finstrument-functions). @xiaoxiang781216 since you've been migrating repeating flags for boards, is there a general place where this could be added?
   
   It's better to move the common toolchain flag to arch(e.g. https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/Toolchain.defs), so all boards can get the same feature support at the same time. Since the duplication setting is huge we can do the movement step by step.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2756: nrf52: add stackcheck support

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2756:
URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768255113


   This requires the appropriate build flag (-finstrument-functions). @xiaoxiang781216 since you've been migrating repeating flags for boards, is there a general place where this could be added?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2756: nrf52: add stackcheck support

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2756:
URL: https://github.com/apache/incubator-nuttx/pull/2756#issuecomment-768262924


   Ok, we can do that later then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org