You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/19 09:47:06 UTC
[GitHub] [shardingsphere] totalo opened a new pull request #10391: Add etcd lock
totalo opened a new pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391
Add etcd lock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#issuecomment-844712140
> Aha, @totalo Thanks, @menghaoranss Please have a look here.
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
totalo commented on pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#issuecomment-844709314
> Hi is there any issue relevant to this PR? @totalo
No, I just found todo and tried to fix it.:-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#discussion_r636767505
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +129,36 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ return false;
Review comment:
ok ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a change in pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
totalo commented on a change in pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#discussion_r636915885
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +131,37 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("etcdRepository tryLock error, key = {}, time = {}, unit = {}", key, time, unit, ex);
+ return false;
+ }
}
-
+
@Override
public void releaseLock(final String key) {
- // TODO
+ try {
+ client.getLockClient().unlock(ByteSequence.from(key, StandardCharsets.UTF_8)).get(etcdProperties.getValue(EtcdPropertyKey.CONNECTION_TIMEOUT_SECONDS), TimeUnit.SECONDS);
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("etcdRepository releaseLock error, key = {}", key, ex);
Review comment:
ok i have fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#issuecomment-844703802
Hi is there any issue relevant to this PR? @totalo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#discussion_r636603769
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +129,36 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ return false;
Review comment:
The exception need be printed by @slf4j
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +129,36 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ return false;
+ }
}
-
+
@Override
public void releaseLock(final String key) {
- // TODO
+ try {
+ client.getLockClient().unlock(ByteSequence.from(key, StandardCharsets.UTF_8)).get(etcdProperties.getValue(EtcdPropertyKey.CONNECTION_TIMEOUT_SECONDS), TimeUnit.SECONDS);
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ // do nothing
Review comment:
The exception need be printed by @slf4j, and remove // do nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on a change in pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#discussion_r636842292
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +131,37 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("etcdRepository tryLock error, key = {}, time = {}, unit = {}", key, time, unit, ex);
+ return false;
+ }
}
-
+
@Override
public void releaseLock(final String key) {
- // TODO
+ try {
+ client.getLockClient().unlock(ByteSequence.from(key, StandardCharsets.UTF_8)).get(etcdProperties.getValue(EtcdPropertyKey.CONNECTION_TIMEOUT_SECONDS), TimeUnit.SECONDS);
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("etcdRepository releaseLock error, key = {}", key, ex);
Review comment:
etcdRepository -> EtcdRepository , key = {} -> key: {}
##########
File path: shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -129,23 +131,37 @@ private Type getEventChangedType(final WatchEvent event) {
return Type.IGNORED;
}
}
-
+
@Override
public boolean tryLock(final String key, final long time, final TimeUnit unit) {
- // TODO
- return false;
+ try {
+ long leaseId = client.getLeaseClient().grant(etcdProperties.getValue(EtcdPropertyKey.TIME_TO_LIVE_SECONDS)).get().getID();
+ client.getLockClient().lock(ByteSequence.from(key, StandardCharsets.UTF_8), leaseId).get(time, unit);
+ return true;
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("etcdRepository tryLock error, key = {}, time = {}, unit = {}", key, time, unit, ex);
Review comment:
etcdRepository -> EtcdRepository , key = {} -> key: {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#issuecomment-844709947
Aha, @totalo Thanks, @menghaoranss Please have a look here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391#issuecomment-845988261
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10391](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c293c2) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1f3671ae829af9fbc9a82b14fe463655b82dcfdf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f3671a) will **increase** coverage by `0.11%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10391 +/- ##
============================================
+ Coverage 68.28% 68.39% +0.11%
- Complexity 696 701 +5
============================================
Files 1740 1750 +10
Lines 29740 29850 +110
Branches 5348 5354 +6
============================================
+ Hits 20307 20417 +110
- Misses 7866 7875 +9
+ Partials 1567 1558 -9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ere/governance/repository/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nb3Zlcm5hbmNlL3JlcG9zaXRvcnkvZXRjZC9FdGNkUmVwb3NpdG9yeS5qYXZh) | `83.63% <54.54%> (-3.04%)` | `18.00 <3.00> (+3.00)` | :arrow_down: |
| [...ernance/repository/etcd/props/EtcdPropertyKey.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nb3Zlcm5hbmNlL3JlcG9zaXRvcnkvZXRjZC9wcm9wcy9FdGNkUHJvcGVydHlLZXkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...istry/checker/EncryptRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL0VuY3J5cHRSdWxlQ29uZmlndXJhdGlvbkNoZWNrZXIuamF2YQ==) | `33.33% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...stry/checker/ShardingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL1NoYXJkaW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `33.33% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...er/ReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL1JlYWR3cml0ZVNwbGl0dGluZ1J1bGVDb25maWd1cmF0aW9uQ2hlY2tlci5qYXZh) | `33.33% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
| [...actReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL0Fic3RyYWN0UmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `14.28% <0.00%> (-57.15%)` | `1.00% <0.00%> (ø%)` | |
| [...gistry/checker/ShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uQ2hlY2tlci5qYXZh) | `25.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ker/DatabaseDiscoveryRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL0RhdGFiYXNlRGlzY292ZXJ5UnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `25.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
| [...dl/impl/ShardingCreateTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZGRsL2ltcGwvU2hhcmRpbmdDcmVhdGVUYWJsZVN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `40.00% <0.00%> (-40.00%)` | `0.00% <0.00%> (ø%)` | |
| [...atement/impl/PostgreSQLTCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `80.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | |
| ... and [33 more](https://codecov.io/gh/apache/shardingsphere/pull/10391/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f3671a...7c293c2](https://codecov.io/gh/apache/shardingsphere/pull/10391?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10391: Add etcd lock
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #10391:
URL: https://github.com/apache/shardingsphere/pull/10391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org