[GitHub] [ozone] adoroszlai commented on a diff in pull request #3853: HDDS-7290. provide a config to increase the list batch size in OzoneFileSystem

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3853:
URL: https://github.com/apache/ozone/pull/3853#discussion_r998551928


##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3358,5 +3358,25 @@
     </description>
   </property>
 
+  <property>
+    <name>ozone.client.fs.listing.page.size</name>
+    <value>1024</value>
+    <tag>OZONE, CLIENT</tag>
+    <description>
+      Default listing page size value used for listing items on fs related sub-commands output. Kindly set
+      this config value responsibly to avoid high resource usage. Maximum value restricted is 5000 for
+      optimum performance.
+    </description>
+  </property>
 
+  <property>
+    <name>ozone.server.fs.listing.page.size</name>
+    <value>1024</value>
+    <tag>OZONE, OM</tag>
+    <description>
+      Default listing page size value used for listing items on fs related sub-commands output. Kindly set
+      this config value responsibly to avoid high resource usage. Maximum value restricted is 5000 for
+      optimum performance.
+    </description>
+  </property>

Review Comment:
   I think name and description should reflect that it's an upper bound on page size from client, not the actual one.  (Now the "max" config from initial patch makes sense with server-side constraint.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org