You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/17 10:56:51 UTC
[GitHub] [solr] janhoy opened a new pull request, #1295: Use $scope.isPermitted("my-permissiong") in security dash
janhoy opened a new pull request, #1295:
URL: https://github.com/apache/solr/pull/1295
Re-using this global function, we can simplify the js code of the dashboard. Note that the backend `/admin/info/system` already returns an array of user's permissions, not roles.
During testing I found that the app.js `isPermitted()` function did not support the `all` permission, so that's why I added that as well.
This can probably be folded in with #1294, but I wanted to separate it for clarity first.
The `roleMatch()` function that I patched in that PR is still in use one other place in `security.js`, in the `onPermFilterOptionChanged()` function. Not sure if we can get rid of that too here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1295: Use $scope.isPermitted("my-permissiong") in security dash
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1399254159
@janhoy we proobably should up our Javascript game, and do it in conjunction with a lint checker to ensure if we migrate to new ways, we don't slip back... I've used `jshint` on Quepid and it works well... I took a quick stab at getting it into gradle, but ended up stumbling on Gradle just never makes sense to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1295: Use $scope.isPermitted("my-permissiong") in security dash
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1398076527
Would be great to get a quick review by @thelabdude on the security panel related changes.
@epugh Should we now use `var` and `const` everywhere instead of `let`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1295: Use $scope.isPermitted("my-permissiong") in security dash
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1385290310
I also found that `security.js` redefined the global `$scope.permissions` also defined in `app.js` which holds a static map of all permission names. I renamed the variable to `$scope.permissionsConfig` to avoid this, although I cannot really find any direct use in html angular directives, so I think it caused no bugs. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1295: SOLR-16621 Use $scope.isPermitted("my-permissiong") in security dash
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #1295:
URL: https://github.com/apache/solr/pull/1295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org