[GitHub] cloud-fan commented on a change in pull request #23358: [SPARK-26424][SQL] Use java.time API in date/timestamp expressions

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23358: [SPARK-26424][SQL] Use java.time API in date/timestamp expressions
URL: https://github.com/apache/spark/pull/23358#discussion_r243719832
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/util/DateFormatterSuite.scala
 ##########
 @@ -89,4 +89,10 @@ class DateFormatterSuite extends SparkFunSuite with SQLHelper {
       }
     }
   }
+
+  test("parsing date with locale") {
 
 Review comment:
   all other tests in this suite have locale, is this test really to test locale?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org