[GitHub] [iceberg] massdosage edited a comment on pull request #1557: Hive: Fix for missing table schema in map reduce job configurations

[GitBox <gi...@apache.org>]

massdosage edited a comment on pull request #1557:
URL: https://github.com/apache/iceberg/pull/1557#issuecomment-705584192


   > Looks reasonable to me, but will this affect jobs that run multiple scans in a single MR stage?
   > 
   > @massdosage, do we have HiveRunner tests for joins that run a two table scans in a stage?
   
   I think this does it: https://github.com/ExpediaGroup/iceberg/blob/master/mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerBaseTest.java#L145 as @pvary mentioned above. I know this caught an issue with multiple tables not being configured for the scan properly in the past but it's possible it doesn't capture all the cases that can occur.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org