You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ye...@apache.org on 2009/12/21 15:51:40 UTC

svn commit: r892839 - in /poi/trunk/src: documentation/content/xdocs/ java/org/apache/poi/hssf/dev/ java/org/apache/poi/hssf/usermodel/ java/org/apache/poi/ss/usermodel/ ooxml/java/org/apache/poi/xssf/usermodel/

Author: yegor
Date: Mon Dec 21 14:51:39 2009
New Revision: 892839

URL: http://svn.apache.org/viewvc?rev=892839&view=rev
Log:
improved javadoc on Picture.resize()

Modified:
    poi/trunk/src/documentation/content/xdocs/status.xml
    poi/trunk/src/java/org/apache/poi/hssf/dev/BiffViewer.java
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPicture.java
    poi/trunk/src/java/org/apache/poi/ss/usermodel/Picture.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java

Modified: poi/trunk/src/documentation/content/xdocs/status.xml
URL: http://svn.apache.org/viewvc/poi/trunk/src/documentation/content/xdocs/status.xml?rev=892839&r1=892838&r2=892839&view=diff
==============================================================================
--- poi/trunk/src/documentation/content/xdocs/status.xml (original)
+++ poi/trunk/src/documentation/content/xdocs/status.xml Mon Dec 21 14:51:39 2009
@@ -34,6 +34,7 @@
 
     <changes>
         <release version="3.7-SNAPSHOT" date="2010-??-??">
+          <action dev="POI-DEVELOPERS" type="fix">48415 - improved javadoc on HSSPicture.resize() </action>
            <action dev="POI-DEVELOPERS" type="add">added Ant target to install artifacts in local repository </action>
            <action dev="POI-DEVELOPERS" type="fix">48026 - fixed PageSettingsBlock to allow multiple HeaderFooterRecord records </action>
            <action dev="POI-DEVELOPERS" type="fix">48202 - fixed CellRangeUtil.mergeCellRanges to work for adjacent cell regions </action>

Modified: poi/trunk/src/java/org/apache/poi/hssf/dev/BiffViewer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/dev/BiffViewer.java?rev=892839&r1=892838&r2=892839&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/dev/BiffViewer.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/dev/BiffViewer.java Mon Dec 21 14:51:39 2009
@@ -294,7 +294,7 @@
 			boolean noint = false;
 			boolean out = false;
 			boolean rawhex = false;
-            boolean header = false;
+            boolean header = true;
 			File file = null;
 			for (int i=0; i<nArgs; i++) {
 				String arg = args[i];

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPicture.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPicture.java?rev=892839&r1=892838&r2=892839&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPicture.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPicture.java Mon Dec 21 14:51:39 2009
@@ -78,6 +78,11 @@
 
     /**
      * Resize the image
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with default font size (Arial 10pt for .xls).
+     * If the default font is changed the resized image can be streched vertically or horizontally.
+     * </p>
      *
      * @param scale the amount by which image dimensions are multiplied relative to the original size.
      * <code>resize(1.0)</code> sets the original size, <code>resize(0.5)</code> resize to 50% of the original,
@@ -103,6 +108,12 @@
 
     /**
      * Reset the image to the original size.
+     * 
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with default font size (Arial 10pt for .xls).
+     * If the default font is changed the resized image can be streched vertically or horizontally.
+     * </p>
      */
     public void resize(){
         resize(1.0);

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/Picture.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/Picture.java?rev=892839&r1=892838&r2=892839&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/Picture.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/Picture.java Mon Dec 21 14:51:39 2009
@@ -25,12 +25,24 @@
 
     /**
      * Reset the image to the original size.
+     *
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with default font size (Arial 10pt for .xls and Calibri 11pt for .xlsx).
+     * If the default font is changed the resized image can be streched vertically or horizontally.
+     * </p>
      */
     void resize();
 
     /**
      * Reset the image to the original size.
      *
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with default font size (Arial 10pt for .xls and Calibri 11pt for .xlsx).
+     * If the default font is changed the resize() procedure can be 'off'.
+     * </p>
+     *
      * @param scale the amount by which image dimensions are multiplied relative to the original size.
      * <code>resize(1.0)</code> sets the original size, <code>resize(0.5)</code> resize to 50% of the original,
      * <code>resize(2.0)</code> resizes to 200% of the original.

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java?rev=892839&r1=892838&r2=892839&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java Mon Dec 21 14:51:39 2009
@@ -149,6 +149,12 @@
 
     /**
      * Reset the image to the original size.
+     *
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with the default font size (Calibri 11pt for .xlsx).
+     * If the default font is changed the resized image can be streched vertically or horizontally.
+     * </p>
      */
     public void resize(){
         resize(1.0);
@@ -156,6 +162,11 @@
 
     /**
      * Reset the image to the original size.
+     * <p>
+     * Please note, that this method works correctly only for workbooks
+     * with the default font size (Calibri 11pt for .xlsx).
+     * If the default font is changed the resized image can be streched vertically or horizontally.
+     * </p>
      *
      * @param scale the amount by which image dimensions are multiplied relative to the original size.
      * <code>resize(1.0)</code> sets the original size, <code>resize(0.5)</code> resize to 50% of the original,



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org