[GitHub] [arrow] icexelloss commented on pull request #14352: ARROW-17642: [C++] Add ordered aggregation

[GitBox <gi...@apache.org>]

icexelloss commented on PR #14352:
URL: https://github.com/apache/arrow/pull/14352#issuecomment-1328270191

   Does the non ordered / hash aggregation handles  chunk array?
   
   On Sun, Nov 27, 2022 at 4:07 PM rtpsw ***@***.***> wrote:
   
   > I'm still pretty reluctant to add code to handle chunked arrays. I feel it
   > adds complexity that we will end up maintaining when chunked arrays don't
   > really have a place in a streaming execution engine (since we process
   > things once batch at a time usually).
   >
   > This is understandable. I'll try to drop support for chunked arrays in
   > this PR and report back on what seems to break; we may be able to find an
   > alternative approach.
   >
   > My investigation suggests that the reason for introducing chunks in the
   > first place is that the testers use tables, and their implementing class
   > SimpleTable has ChunkedArray columns (even after CombineChunks) that the
   > aggregation code needs to handle. Therefore, if we remove support for
   > chunked arrays in the aggregation code, then it won't work nicely with
   > table inputs. AFAIU, aggregating tables is a valid use case that should be
   > supported. @westonpace <https://github.com/westonpace>, let me know you
   > thoughts.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/arrow/pull/14352#issuecomment-1328266070>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAGBXLDTXW4NCU2VWOULFW3WKN2M5ANCNFSM6AAAAAARANAUMQ>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org