You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/11 19:24:09 UTC
[GitHub] graceguo-supercat commented on a change in pull request #3834: [Dashboard bug] Slice doesn't always show loading icon when loading
graceguo-supercat commented on a change in pull request #3834: [Dashboard bug] Slice doesn't always show loading icon when loading
URL: https://github.com/apache/incubator-superset/pull/3834#discussion_r150391334
##########
File path: superset/assets/javascripts/chart/Chart.jsx
##########
@@ -146,7 +146,7 @@ class Chart extends React.PureComponent {
}
render() {
- const isLoading = this.props.chartStatus === 'loading';
+ const isLoading = [undefined, 'loading'].indexOf(this.props.chartStatus) !== -1;
Review comment:
this `isLoading` logic is to show <Loading> component when fetching query data.
I remember you mentioned want to keep `loading` related logic inside `Chart`:
https://github.com/apache/incubator-superset/pull/3581/commits/ab59c4ccc1beeb446d9691f3384ec4e9e1754f6b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services