You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 21:53:16 UTC
[GitHub] [arrow-datafusion] jdye64 opened a new pull request, #2320: deprecate `index_of` and make `index_of_column_by_name` public
jdye64 opened a new pull request, #2320:
URL: https://github.com/apache/arrow-datafusion/pull/2320
Closes #2319
# Are there any user-facing changes?
Along with `index_of` being deprecated the user will be presented with a `DataFusion::Plan` error if they attempt to use `index_of` and supply a fully qualified field name to the function.
No `DataFusion::Plan` error is generated if they use `index_of` and supply an unqualified field name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jdye64 commented on pull request #2320: deprecate `index_of` and make `index_of_column_by_name` public
Posted by GitBox <gi...@apache.org>.
jdye64 commented on PR #2320:
URL: https://github.com/apache/arrow-datafusion/pull/2320#issuecomment-1107945134
So the linter, clippy, is failing due to the use of `index_of` which this PR deprecates. I would like to test invoking that function however.
I would like opinions from people on which `allow` would be preferred to enable that. I feel like that might be a project specific thing so want to check. @xudong963 what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #2320: deprecate `index_of` and make `index_of_column_by_name` public
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #2320:
URL: https://github.com/apache/arrow-datafusion/pull/2320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #2320: deprecate `index_of` and make `index_of_column_by_name` public
Posted by GitBox <gi...@apache.org>.
xudong963 commented on PR #2320:
URL: https://github.com/apache/arrow-datafusion/pull/2320#issuecomment-1108064621
> My first thought would be `#[allow(deprecated)]` but like I said I want to check
I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org