You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "torwig (via GitHub)" <gi...@apache.org> on 2023/06/25 06:57:23 UTC

[GitHub] [kvrocks] torwig commented on a diff in pull request #1489: Add Redis-compatible cursors for `SCAN` commands

torwig commented on code in PR #1489:
URL: https://github.com/apache/kvrocks/pull/1489#discussion_r1241063714


##########
src/config/config.h:
##########
@@ -144,6 +144,7 @@ struct Config {
   int pipeline_size;
   int sequence_gap;
 
+  bool redis_cursor_compatible = true;

Review Comment:
   I just wondering why the initial value is `true`? As I see in the `.cc` file we have the default value as `false` for this variable.
   Other LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org