[jira] [Commented] (LUCENE-6394) Add two-phase support to SpanNotQuery

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485222#comment-14485222 ] 

Adrien Grand commented on LUCENE-6394:
--------------------------------------

I like the patch, two minor things that got me wondering while reading the patch:
 - Should SpansCell still extend FilterSpans and return always YES? This would avoid reimplementing Spans from scratch?
 - It took me some time to compile how FilterSpans.twoPhaseCurrentDocMatches works, with its infinite loop, conditional fallthrough, etc. maybe it could be written in a more straightforward way?

> Add two-phase support to SpanNotQuery
> -------------------------------------
>
>                 Key: LUCENE-6394
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6394
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6394.patch, LUCENE-6394.patch, LUCENE-6394.patch
>
>
> This query is actually a lot like SpanPositionCheckQuery, except it checks that each inclusion Spans does not come near the exclusion side.
> Two-phase iteration should just work the inclusion side, deferring positions (the overlap checking against exclusion) until necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org