[GitHub] [pulsar] Jason918 commented on a change in pull request #14342: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about subscribeRate

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #14342:
URL: https://github.com/apache/pulsar/pull/14342#discussion_r810467680



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -316,11 +328,19 @@ private void updateTopicPolicyByBrokerConfig() {
         if (isSystemTopic()) {
             schemaCompatibilityStrategy = config.getSystemTopicSchemaCompatibilityStrategy();
         }
+        topicPolicies.getSubscribeRate().updateBrokerValue(subscribeRate(config));
         topicPolicies.getSubscriptionDispatchRate().updateBrokerValue(subscriptionDispatchRateInBroker(config));
         topicPolicies.getSchemaCompatibilityStrategy()
                 .updateBrokerValue(formatSchemaCompatibilityStrategy(schemaCompatibilityStrategy));
     }
 
+    private SubscribeRate subscribeRate(ServiceConfiguration config) {

Review comment:
       Let's keep the naming consistent with others, or just not using a simple method to wrap this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org