You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/04/27 09:30:00 UTC

[jira] [Resolved] (ARROW-11990) [C++][Compute] Use Status/Result return consistently to indicate errors

     [ https://issues.apache.org/jira/browse/ARROW-11990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Pitrou resolved ARROW-11990.
------------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

Issue resolved by pull request 10098
[https://github.com/apache/arrow/pull/10098]

> [C++][Compute] Use Status/Result return consistently to indicate errors
> -----------------------------------------------------------------------
>
>                 Key: ARROW-11990
>                 URL: https://issues.apache.org/jira/browse/ARROW-11990
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 1.0.0
>            Reporter: Ben Kietzman
>            Assignee: Yibo Cai
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Discussion on ML: https://lists.apache.org/thread.html/r7c369390dd0b99edb1e4529920e06e62a1f65802bcdfb34317436fac%40%3Cdev.arrow.apache.org%3E
> Wherever there is not a motivating performance reason for error
> propagation using {{KernelContext::{SetStatus, status}}} remove this in favor of the error pattern used in the rest of the library: returning a Status or (preferably) Result. This will avoid the added cognitive overhead and boilerplate code of interfacing between the different strategies.
> For example, refactor KernelInit from {{unique_ptr<KernelState>(KernelContext*, KernelInitArgs)}} to {{Result<unique_ptr<KernelState>>(ExecContext*, KernelInitiArgs)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)